Prod Deployment Hotfixes#4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment workflow and improves code quality and UI consistency across several components. The most significant changes include renaming and generalizing the deployment workflow for broader production use, updating secrets and variables for deployment, refining navigation highlighting logic, and making layout fixes for better responsiveness.
Deployment workflow improvements:
.github/workflows/deploy-cpanel.ymlto.github/workflows/deploy-prod.yml, updated its name to "Deploy To Production", and generalized concurrency group and environment variables to useFTP_SERVERandFTP_SERVER_DIRinstead of cPanel-specific names. Also updated Node.js version to 24 and switched deployment secrets to the new naming convention. [1] [2] [3]README.mdto reflect the new deployment workflow filename, secrets, and variable names, ensuring documentation matches the code changes.Navigation and UI logic:
Navbar.tsxby introducing anormalizePathhelper and anisActiveLinkfunction, ensuring correct active state for nested routes and removing trailing slashes inconsistencies. [1] [2] [3] [4]Layout and responsiveness fixes:
min-w-0utility classes and adjusted flex/grid layouts inStoriesCarousel.tsxto prevent overflow issues and improve responsiveness. [1] [2] [3] [4]ProcessSteps.tsxvisible on all screen sizes (was previously hidden on non-xl screens).Documentation formatting:
README.mdfor improved readability and consistency. [1] [2] [3] [4]