-
Notifications
You must be signed in to change notification settings - Fork 8
VAN-4202 Added bundle to deploy kube Prometheus stack #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akashcldcvr
wants to merge
14
commits into
main
Choose a base branch
from
akashj/VAN-4202
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-example/grafana-promethus/helm/kube-prometheus-stack/charts/kube-state-metrics-5.7.0.tgz
Show resolved
Hide resolved
kanaksinghal
previously approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder structure is not clear to me: helm-example/grafana-promethus/helm/kube-prometheus-stack
helm-example- why is it called example? is it not usable, it is just example?helm-example/grafana-promethus/helm- it seems that the real helm charts are inside this folder, I'm not sure can we removehelm-example/grafana-promethusand have justhelm/kube-prometheus-stack&helm/loki-stacksuch that whoever wants to use these helm charts can use from thehelmdirectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.