Conversation
|
| Filename | Overview |
|---|---|
| nominal/experimental/containerized/_decorators.py | New decorator that auto-wires files, secrets, and parameters from environment variables into decorated function kwargs. Includes thorough signature validation. One style concern: caller-provided kwargs are silently overwritten. |
| nominal/experimental/containerized/init.py | Simple re-export of containerized_env_inputs from the private _decorators module. Clean and standard. |
| tests/test_containerized_env_inputs.py | Good test coverage: validates env var injection, typing.List/Dict annotation support, missing parameter detection, and wrong-type annotation detection. |
| uv.lock | Version bump from 1.113.0 to 1.114.0 in lockfile. No concerns. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["@containerized_env_inputs applied"] --> B["Validate signature: files: list, secrets: dict, parameters: dict"]
B -->|Invalid| C["Raise TypeError"]
B -->|Valid| D["Return wrapped function"]
D --> E["Wrapped function called"]
E --> F["Read os.environ for __nominal_file_*, __nominal_secret_*, __nominal_parameter_*"]
F --> G["Inject files, secrets, parameters into kwargs"]
G --> H["Call original function with injected kwargs"]
Last reviewed commit: 1e9c71e
| @@ -0,0 +1 @@ | |||
| Subproject commit 9ead43bd9fa9d546aa0330582250e1eeabec0184 | |||
There was a problem hiding this comment.
Submodule added without .gitmodules
This file is tracked as a git submodule (mode 160000), but there is no .gitmodules file in the repository to define the remote URL for nominal-containerized-env-inputs. Without .gitmodules, git submodule init and git clone --recurse-submodules will fail for anyone cloning the repo — the submodule reference will appear as an empty directory with no way to resolve the commit 9ead43b.
You need to either:
- Add a
.gitmodulesfile with the[submodule "nominal-containerized-env-inputs"]section specifying thepathandurl, or - If this was unintentionally committed (e.g., a nested git repo), remove the submodule entry and add the path to
.gitignore.
Prompt To Fix With AI
This is a comment left during a code review.
Path: nominal-containerized-env-inputs
Line: 1
Comment:
**Submodule added without `.gitmodules`**
This file is tracked as a git submodule (mode `160000`), but there is no `.gitmodules` file in the repository to define the remote URL for `nominal-containerized-env-inputs`. Without `.gitmodules`, `git submodule init` and `git clone --recurse-submodules` will fail for anyone cloning the repo — the submodule reference will appear as an empty directory with no way to resolve the commit `9ead43b`.
You need to either:
1. Add a `.gitmodules` file with the `[submodule "nominal-containerized-env-inputs"]` section specifying the `path` and `url`, or
2. If this was unintentionally committed (e.g., a nested git repo), remove the submodule entry and add the path to `.gitignore`.
How can I resolve this? If you propose a fix, please make it concise.
No description provided.