feat: forcefully remove top-level functionality#531
Open
drake-nominal wants to merge 2 commits intomainfrom
Open
feat: forcefully remove top-level functionality#531drake-nominal wants to merge 2 commits intomainfrom
drake-nominal wants to merge 2 commits intomainfrom
Conversation
drake-nominal
force-pushed
the
deidukas/feat-remove-deprecated-stuff
branch
from
e8ff44b to
a3ba4b7
Compare
drake-nominal
force-pushed
the
deidukas/feat-remove-deprecated-stuff
branch
from
a3ba4b7 to
6f7bc7a
Compare
alkasm
reviewed
Dec 1, 2025
| case "get_user": | ||
| raise ImportError( | ||
| f"nominal.get_user has been removed. " | ||
| f"Use `nominal.core.NominalClient.get_user` instead, see {AUTHENTICATION_DOCS_LINK}" |
Contributor
There was a problem hiding this comment.
auth link is probably not relevant?
Base automatically changed from
deidukas/feat-remove-deprecated-stuff
to
main
December 2, 2025 03:54
stefanv
reviewed
Jan 22, 2026
Collaborator
stefanv
left a comment
stefanv
left a comment
There was a problem hiding this comment.
Thanks for handling all these outstanding deprecations. After the next sync with main, we should get it merged so it doesn't drift into conflicts again.
Are there any plans for end-to-end or other testing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.