feat: massively expand functionality on assets and runs#527
Draft
drake-nominal wants to merge 6 commits intomainfrom
Draft
feat: massively expand functionality on assets and runs#527drake-nominal wants to merge 6 commits intomainfrom
drake-nominal wants to merge 6 commits intomainfrom
Conversation
alkasm
reviewed
Nov 19, 2025
f3ca2b8 to
a9b2044
Compare
935497d to
ceb0e48
Compare
db092b1 to
620d0e3
Compare
9435b40 to
eaf2c10
Compare
0df4358 to
75562b5
Compare
…sset runs in client
75562b5 to
028a1fa
Compare
028a1fa to
13b1e38
Compare
13b1e38 to
af60479
Compare
af60479 to
967fabf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Make assets and runs way more powerful. Instead of needing to handle runs and asset objects, or even think about dataset objects, now users can work with mostly just assets. A typical ingestion flow would now look like:
A future change I want to make is to allow users to pass a
Runintoadd_tabular_dataso thatingestwill update the run bounds upon ingestion completion. I also want to allow users topoll_until_ingestion_completed()on both anAssetandRun-- also left as future work.Another future change I would like to make is exposing a
as_completed()variant for dataset files, and to also make it easier to retrieve dataset files for runs, assets (e.g.get_dataset_files("data_scope_name", start_time=..., end_time=...)).Deprecations
NominalClient.search_runs_by_asset=>Asset.search_runsAddditions to NominalClient
assetsshould be preferred overasset, with the former potentially deserving deprecation.Additions to Asset
add_datautilities that take in datascope name & parameters that would normally be passed to their equivalents in the Dataset class:add_tabular_dataadd_journal_jsonadd_mcapadd_ardupilot_dataflashadd_containerizedadd_from_iopromote: promote an implicitly created asset from a run into a full on assetcreate_runcreate_eventcreate_workbooklist_runsAdditions to Run
add_datautilities that take in datascope name & parameters that would normally be passed to their equivalents in the Dataset class:add_tabular_dataadd_journal_jsonadd_mcapadd_ardupilot_dataflashadd_containerizedadd_from_ioget_or_create_datasetget_or_create_videocreate_event: targets all assets present on a runcreate_workbookget_datasetget_videoget_connectionunarchive