better bad request reporting #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiergarea
reviewed
May 23, 2025
Member
javiergarea
left a comment
javiergarea
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a good first step to improve the error reporting.
I included a small suggestion, but LGTM overall 🚀
Comment on lines
+331
to
338
| erl_syntax:application( | ||
| erl_syntax:atom(erf_util), | ||
| erl_syntax:atom(handle_invalid_request), | ||
| [ | ||
| erl_syntax:integer(400), | ||
| erl_syntax:list([]), | ||
| erl_syntax:atom(undefined) | ||
| erl_syntax:variable('Request'), | ||
| erl_syntax:variable('Reason') | ||
| ] | ||
| ) |
Member
There was a problem hiding this comment.
[
erl_syntax:tuple(
[
erl_syntax:integer(400),
erl_syntax:list([]),
erl_syntax:application(
erl_syntax:atom(io_lib),
erl_syntax:atom(print),
[erl_syntax:variable('Reason')]
)
]
)
]
Member
There was a problem hiding this comment.
Would you mind moving the handle_invalid_request function to an inline check like the above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hardcoded hook to show the user some info on request badness.
May be extended later to support rfc9457 as requested in #66