Removed custom_output_names from the separate file call.#260
Removed custom_output_names from the separate file call.#260Kulin-Soni wants to merge 1 commit intonomadkaraoke:mainfrom
Conversation
Removed custom_output_names from _separate_file call inside the _process_with_chunking method. This prevents the processed chunks from getting the same custom name, and rather have the `chunk_N` naming.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA parameter removal from a function call in the chunked audio processing method. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can you make sure all the tests pass too please? 🙏 |
Removed custom_output_names from _separate_file call inside the _process_with_chunking method. This prevents the processed chunks from getting the same custom name, and have the
chunk_Nnaming.This prevents overwriting previous chunks.
This is a fix to #259
Summary by CodeRabbit
Release Notes