Add support for newer nodejs versions, in the form of '5.x'.#21
Add support for newer nodejs versions, in the form of '5.x'.#21mtpereira wants to merge 5 commits intonodesource:masterfrom mtpereira:add_support_for_new_versions
Conversation
defaults/main.yml
Outdated
There was a problem hiding this comment.
I think it might be wise to pin this to 4.x rather than 5.x because those who use Ansible are more likely to be LTS type users and v5.x is only going to last a max of 8 months so we'll be updating this config pretty soon.
There was a problem hiding this comment.
Hello,
You're absolutely right, will fix it.
Thank you.
On Wed, Nov 18, 2015 at 3:34 AM, Rod Vagg notifications@github.com wrote:
In defaults/main.yml
#21 (comment)
:@@ -2,5 +2,5 @@
Pin-Priority of NodeSource repository
nodejs_nodesource_pin_priority: 500
-# 0.10 or 0.12 or 4.x
-nodejs_version: "4.2"
+# 0.10 or 0.12 and 4.x, 5.x and onward
+nodejs_version: "5.0"I think it might be wise to pin this to 4.x rather than 5.x because
those who use Ansible are more likely to be LTS type users and v5.x is only
going to last a max of 8 months so we'll be updating this config pretty
soon.—
Reply to this email directly or view it on GitHub
https://github.com/nodesource/ansible-nodejs-role/pull/21/files#r45156477
.
Manuel Tiago Pereira
|
@wolfeidau if you have time could you please review this? It looks good to me aside from my concern re v4.x vs v5.x. |
|
We're now installing LTS (https://nodejs.org/en/blog/release/v4.2.0/) by default. |
Previous regex wasn't working for me.
Hello,
Following PRs #19 and #20 , here's a fix for support on newer versions, whilst still maintaining compatibility with older versions' repositories.
Thank you.