feat(DEP0121): `net._setSimultaneousAccepts()` by vespa7 · Pull Request #278 · nodejs/userland-migrations

vespa7 · 2025-11-19T13:14:23Z

Closes #173

Closes nodejs#173

package.json

recipes/net-setSimultaneousAccepts-migration/README.md

AugustinMauroy

Missing test case for dynamic import

vespa7 · 2025-11-19T22:32:26Z

Missing test case for dynamic import

Yes, it’s in draft. It doesn’t need to be corrected yet. I’m waiting for a question to be resolved.

JakobJingleheimer · 2025-11-20T09:02:53Z

Yes, it’s in draft. It doesn’t need to be corrected yet. I’m waiting for a question to be resolved.

I don't see a question. Is it something we can help with? (Could you point us to it?)

AugustinMauroy · 2025-11-28T08:25:58Z

package.json

    "codemod",
    "migrations",
-    "node.js"
+    "node.js"  


Suggested change

"node.js"

"node.js"

AugustinMauroy · 2025-11-28T08:26:49Z

What the current state of this pr ?

vespa7 · 2025-11-28T10:56:14Z

What the current state of this pr ?

The PR is ready to be reviewed.

AugustinMauroy

not too bad, good job but there are serval part of the implementation that need to be discussed

AugustinMauroy · 2025-11-29T17:42:54Z

recipes/net-setSimultaneousAccepts-migration/codemod.yaml

@@ -0,0 +1,21 @@
+schema_version: "1.0"
+name: "@nodejs/net-setSimultaneousAccepts-migration"


Suggested change

name: "@nodejs/net-setSimultaneousAccepts-migration"

name: "@nodejs/net-setSimultaneousAccepts-deprecation"

#namingIsHard @nodejs/userland-migrations what do you think

Mm, the suggestion is more correct.

AugustinMauroy · 2025-11-29T17:44:09Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	const linesToRemove: Range[] = [];
+
+	const netImportStatements = getAllNetImportStatements(root);
+	if (netImportStatements.length === 0) return null;


Suggested change

if (netImportStatements.length === 0) return null;

// If no import found we don't process the file

if (!netImportStatements.length) return null;

AugustinMauroy · 2025-11-29T17:44:59Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		processNetImportStatement(rootNode, statement, linesToRemove, edits);
+	}
+
+	if (edits.length === 0 && linesToRemove.length === 0) return null;


Suggested change

if (edits.length === 0 && linesToRemove.length === 0) return null;

// If there aren't any change we don't try to modify something

if (!edits.length && !linesToRemove.length) return null;

Maybe "No changes, nothing to do" for the comment

AugustinMauroy · 2025-11-29T17:46:22Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		...getNodeImportStatements(root, 'node:net'),
+		...getNodeImportCalls(root, 'node:net'),
+		...getNodeRequireCalls(root, 'node:net'),


Suggested change

...getNodeImportStatements(root, 'node:net'),

...getNodeImportCalls(root, 'node:net'),

...getNodeRequireCalls(root, 'node:net'),

...getNodeImportStatements(root, 'net'),

...getNodeImportCalls(root, 'net'),

...getNodeRequireCalls(root, 'net'),

the node: isn't needed theses functions catch it

AugustinMauroy · 2025-11-29T17:46:36Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	edits: Edit[]
+): void {
+	const bindingPath = resolveBindingPath(statementNode, '$');
+	if (!bindingPath) return;


Suggested change

if (!bindingPath) return;

if (!bindingPath) return;

AugustinMauroy · 2025-11-29T17:47:37Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+/**
+ * Finds all _setSimultaneousAccepts() call expressions
+ */
+function findSetSimultaneousAcceptsCalls(


This function isn't valuable. You can "hardcode" this query in the parent functio

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

AugustinMauroy · 2025-11-29T17:49:53Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	for (const objDecl of objDeclarations) {
+		const objectLiterals = objDecl.findAll({ rule: { kind: 'object' } });
+
+		for (const obj of objectLiterals) {
+			const pairs = obj.findAll({ rule: { kind: 'pair' } });
+
+			for (const pair of pairs) {
+				const key = pair.child(0);
+				if (key?.text() === propertyName) {
+					const rangeWithComma = expandRangeToIncludeTrailingComma(
+						pair.range(),
+						rootNode.text()
+					);
+					linesToRemove.push(rangeWithComma);
+				}
+			}
+		}
+	}


can we have a loop that push to an array then iterate on this array to avoid 3th level of nested loop

AugustinMauroy · 2025-11-29T17:50:50Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	varName: string,
+	linesToRemove: Range[]
+): void {
+	const varDeclarationStatements = rootNode.findAll({


JakobJingleheimer

Thanks for this! It's a good first :)

I think this could use some additional test-cases that include more things happening from node:net to ensure they don't get broken.

JakobJingleheimer · 2025-11-27T22:32:36Z

package.json

    "codemod",
    "migrations",
-    "node.js"
+    "node.js"  


Suggested change

"node.js"

"node.js"

JakobJingleheimer · 2025-11-27T22:38:22Z

recipes/net-setSimultaneousAccepts-migration/README.md

+const net = require("node:net");
+
+-net._setSimultaneousAccepts(false);
+ const server = net.createServer();


Suggested change

const net = require("node:net");

-net._setSimultaneousAccepts(false);

const server = net.createServer();

const net = require("node:net");

- net._setSimultaneousAccepts(false);

const server = net.createServer();

JakobJingleheimer · 2025-11-30T15:28:32Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		processNetImportStatement(rootNode, statement, linesToRemove, edits);
+	}
+
+	if (edits.length === 0 && linesToRemove.length === 0) return null;


Maybe "No changes, nothing to do" for the comment

JakobJingleheimer · 2025-12-01T09:37:29Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	if (argKind === 'member_expression') {
+		handleMemberExpressionArgument(rootNode, argNode, linesToRemove);
+	} else if (argKind === 'identifier') {
+		handleIdentifierArgument(rootNode, argNode, linesToRemove);
+	}


nit: switch makes it more clear that it's inspecting the same condition for each.

Suggested change

if (argKind === 'member_expression') {

handleMemberExpressionArgument(rootNode, argNode, linesToRemove);

} else if (argKind === 'identifier') {

handleIdentifierArgument(rootNode, argNode, linesToRemove);

}

switch(argKind) {

case 'member_expression': handleMemberExpressionArgument(rootNode, argNode, linesToRemove); break;

case 'identifier': handleIdentifierArgument(rootNode, argNode, linesToRemove); break;

}

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

JakobJingleheimer

This looks good to me! I see there is some uncertainty (#173 (comment)) about the proper handling for this, so let's get someone from @nodejs/net to chime in before landing.

PS Sorry this took me a while to get back to.

JakobJingleheimer · 2026-02-22T13:24:41Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+/**
+ * Collects all import/require statements for 'node:net'
+ */
+function getAllNetImportStatements(root: SgRoot<Js>): SgNode<Js>[] {
+	return [
+		...getNodeImportStatements(root, 'net'),
+		...getNodeImportCalls(root, 'net'),
+		...getNodeRequireCalls(root, 'net'),
+	];
+}


After this PR was opened, we added this as a built-in utility: @nodejs/codemod-utils:getModuleDependencies

JakobJingleheimer · 2026-02-22T13:27:11Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+	const netImportStatements = getAllNetImportStatements(root);
+
+	// If no import found we don't process the file
+	if (!netImportStatements.length) return null;
+
+	for (const statement of netImportStatements) {
+		processNetImportStatement(rootNode, statement, linesToRemove, edits);
+	}


The length check is unnecessary: getAllNetImportStatements (and @nodejs/codemod-utils:getModuleDependencies) always return an array, so the for…of won't break and will simply do nothing when the array is empty; then the check right after will handle aborting, affectively achieving the same thing with less code.

Suggested change

const netImportStatements = getAllNetImportStatements(root);

// If no import found we don't process the file

if (!netImportStatements.length) return null;

for (const statement of netImportStatements) {

processNetImportStatement(rootNode, statement, linesToRemove, edits);

}

for (const statement of getAllNetImportStatements(root)) {

processNetImportStatement(rootNode, statement, linesToRemove, edits);

}

Suggested change

const netImportStatements = getAllNetImportStatements(root);

// If no import found we don't process the file

if (!netImportStatements.length) return null;

for (const statement of netImportStatements) {

processNetImportStatement(rootNode, statement, linesToRemove, edits);

}

for (const statement of getModuleDependencies(root)) {

processNetImportStatement(rootNode, statement, linesToRemove, edits);

}

JakobJingleheimer · 2026-02-22T13:28:07Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+import {
+	getNodeImportStatements,
+	getNodeImportCalls,
+} from '@nodejs/codemod-utils/ast-grep/import-statement';
+import { getNodeRequireCalls } from '@nodejs/codemod-utils/ast-grep/require-call';


nit (see below)

Suggested change

import {

getNodeImportStatements,

getNodeImportCalls,

} from '@nodejs/codemod-utils/ast-grep/import-statement';

import { getNodeRequireCalls } from '@nodejs/codemod-utils/ast-grep/require-call';

import { getModuleDependencies } from '@nodejs/codemod-utils/ast-grep/module-dependencies';

JakobJingleheimer · 2026-02-22T13:32:58Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		if (argNode) {
+			handleCallArgument(rootNode, argNode, linesToRemove);
+		}


nit:

Suggested change

if (argNode) {

handleCallArgument(rootNode, argNode, linesToRemove);

}

if (argNode) handleCallArgument(rootNode, argNode, linesToRemove);

JakobJingleheimer · 2026-02-22T13:35:04Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		case 'member_expression': handleMemberExpressionArgument(rootNode, argNode, linesToRemove); break;
+	    case 'identifier': handleIdentifierArgument(rootNode, argNode, linesToRemove); break;


There's some extra indentation on the second case which at first glance makes it look like nested code.

A nit line-break for the break so it doesn't get (visually) lost and look like fall-through.

Suggested change

case 'member_expression': handleMemberExpressionArgument(rootNode, argNode, linesToRemove); break;

case 'identifier': handleIdentifierArgument(rootNode, argNode, linesToRemove); break;

case 'member_expression': handleMemberExpressionArgument(rootNode, argNode, linesToRemove);

break;

case 'identifier': handleIdentifierArgument(rootNode, argNode, linesToRemove);

break;

JakobJingleheimer · 2026-02-22T13:37:38Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+				index: endPos + 1,
+				column: range.end.column + 1
+			}


nit (formatting/linting)

Suggested change

index: endPos + 1,

column: range.end.column + 1

}

column: range.end.column + 1,

index: endPos + 1,

},

JakobJingleheimer · 2026-02-22T13:38:38Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+		if (topLevelStatement) {
+			linesToRemove.push(topLevelStatement.range());
+		}


nit

Suggested change

if (topLevelStatement) {

linesToRemove.push(topLevelStatement.range());

}

if (topLevelStatement) linesToRemove.push(topLevelStatement.range());

JakobJingleheimer · 2026-02-22T13:58:46Z

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts

+function findTopLevelStatement(node: SgNode<Js>): SgNode<Js> | null {
+	let current: SgNode<Js> | null = node;
+
+	while (current) {
+		const parent = current.parent();
+		if (!parent) break;
+
+		if (parent.kind() === 'program') {
+			return current;
+		}
+
+		current = parent;
+	}
+
+	return null;
+}


I think this can be simplified:

Suggested change

function findTopLevelStatement(node: SgNode<Js>): SgNode<Js> | null {

let current: SgNode<Js> | null = node;

while (current) {

const parent = current.parent();

if (!parent) break;

if (parent.kind() === 'program') {

return current;

}

current = parent;

}

return null;

}

function findTopLevelStatement(node: SgNode<Js>): SgNode<Js> | null {

let current: SgNode<Js> | null = node;

while (current = current.parent()) {

if (current?.kind() === 'program') return current;

}

return null;

}

I checked with a quick test:

function generateNode(kind) { let i = 1; return { parent() { if (i++ < 4) return { kind() { return kind }, }; return null; }, }; } findTopLevelStatement(generateNode('not-program'); // null findTopLevelStatement(generateNode('program'); // { kind: 𝑓 }

JakobJingleheimer · 2026-02-22T14:15:21Z

package.json

    "codemod",
    "migrations",
-    "node.js"
+    "node.js" 


Suggested change

"node.js"

"node.js"

feat(net-setsimultaneousaccepts-migration): create recipe

081d5e8

Closes nodejs#173

AugustinMauroy reviewed Nov 19, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

AugustinMauroy reviewed Nov 19, 2025

View reviewed changes

recipes/net-setSimultaneousAccepts-migration/README.md Show resolved Hide resolved

AugustinMauroy reviewed Nov 19, 2025

View reviewed changes

Remove variable passed to method

9084315

vespa7 marked this pull request as ready for review November 20, 2025 13:50

JakobJingleheimer added the awaiting reviewer Author has responded and needs action from the reviewer label Nov 27, 2025

AugustinMauroy reviewed Nov 28, 2025

View reviewed changes

package.json Outdated

"codemod",

"migrations",

"node.js"

"node.js"

Copy link

Member

AugustinMauroy Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"node.js"

"node.js"

AugustinMauroy reviewed Nov 29, 2025

View reviewed changes

JakobJingleheimer reviewed Dec 1, 2025

View reviewed changes

JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Dec 1, 2025

avivkeller reviewed Dec 18, 2025

View reviewed changes

recipes/net-setSimultaneousAccepts-migration/src/workflow.ts Outdated Show resolved Hide resolved

feat(net-seetsimultaneousaccepts-migration): fix comments

0b17324

vespa7 requested a review from JakobJingleheimer January 16, 2026 00:04

JakobJingleheimer changed the title ~~feat(net-setsimultaneousaccepts-migration): create recipe~~ feat(DEP0121): net._setSimultaneousAccepts() Feb 22, 2026

JakobJingleheimer approved these changes Feb 22, 2026

View reviewed changes

JakobJingleheimer added the info needed label Feb 24, 2026

		@@ -0,0 +1,21 @@
		schema_version: "1.0"
		name: "@nodejs/net-setSimultaneousAccepts-migration"

-	if (edits.length === 0 && linesToRemove.length === 0) return null;
+	// If there aren't any change we don't try to modify something
+	if (!edits.length && !linesToRemove.length) return null;

		case 'member_expression': handleMemberExpressionArgument(rootNode, argNode, linesToRemove); break;
		case 'identifier': handleIdentifierArgument(rootNode, argNode, linesToRemove); break;

Uh oh!

Conversation

vespa7 commented Nov 19, 2025

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

vespa7 commented Nov 19, 2025 • edited by JakobJingleheimer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JakobJingleheimer commented Nov 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Nov 28, 2025

Uh oh!

vespa7 commented Nov 28, 2025

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

vespa7 commented Nov 19, 2025 •

edited by JakobJingleheimer

Loading

JakobJingleheimer Dec 1, 2025 •

edited

Loading