ci: test shared-builtin only on Node.js 24 and 25 #4746
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js 20 and 22 have internal assertion errors when compiled with --shared-builtin-undici/undici-path flag. The error occurs in setupUserModules during process initialization (ERR_INTERNAL_ASSERTION). This is a Node.js bug, not an undici issue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4746 +/- ##
==========================================
- Coverage 92.89% 92.88% -0.01%
==========================================
Files 109 109
Lines 33886 33886
==========================================
- Hits 31478 31475 -3
- Misses 2408 2411 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test-shared-builtinCI job matrix--shared-builtin-undici/undici-pathflag on Node.js 24 and 25Reason
Node.js 20 and 22 bundle undici 6, while this repository is undici 7. When compiled with
--shared-builtin-undici/undici-pathpointing to undici 7, the API incompatibility causesERR_INTERNAL_ASSERTIONduring process initialization.Node.js 24 and 25 bundle undici 7 and work correctly with this flag.