Skip to content

Conversation

@mcollina
Copy link
Member

Fixes #4732

When WebSocketStream fails to connect, return early after rejecting promises to avoid accessing undefined properties.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (7e5cb2d) to head (e040eb9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4733   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files         109      109           
  Lines       33826    33831    +5     
=======================================
+ Hits        31415    31421    +6     
+ Misses       2411     2410    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocketStream throws internal error when cannot open an connection

3 participants