fix: The "optional" label in the signature component is incorrectly positioned#8693
fix: The "optional" label in the signature component is incorrectly positioned#8693canerakdas wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
Fixes the rendering order of the “optional” marker in the Signature header so it can appear in the conventional name?: position, and bumps the @node-core/ui-components package version to ship the UI tweak.
Changes:
- Adjust
SignatureHeaderoutput so the optional?appears before the:delimiter. - Bump
@node-core/ui-componentsversion from1.6.1to1.6.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-components/src/Common/Signature/SignatureHeader/index.tsx | Updates how the signature name/optional marker/colon are rendered to correct the marker position. |
| packages/ui-components/package.json | Patch version bump for publishing the UI change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8693 +/- ##
==========================================
+ Coverage 75.05% 75.10% +0.04%
==========================================
Files 104 104
Lines 9161 9161
Branches 316 315 -1
==========================================
+ Hits 6876 6880 +4
+ Misses 2283 2279 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
SGTM, feel free to fast-track
Description
The "optional"(?) label in the signature component is incorrectly positioned.
Ref: nodejs/doc-kit#637
Validation
Related Issues
Related to nodejs/doc-kit#637