-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: update Devbox package name and fix Turkish snippet #8525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only change the English variation
|
Didn't we remove DevBox because it was a commercial product? |
I have changed this as requested; obviously the fixes for the Turkish version have now disappeared as well |
No. DevBox is still on the website. Although, per https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1744674880071739, I think it should be removed. |
Then we should close this PR and make a new one to remove it. |
Description
This PR corrects the Devbox installation package name from node to nodejs across all localized download snippets. Currently, the download page provides instructions using
devbox add node@version, but the official package name in the Nix/Devbox ecosystem is nodejs. Using node results in a package not found error.Additionally, the Turkish instructions contained two problems:
devboxcommandValidation
The change was validated by cross-referencing the official Devbox package registry on Nixhub, which confirms that nodejs is the correct identifier for the runtime.
See: https://www.nixhub.io/packages/nodejs vs https://www.nixhub.io/packages/node
Related Issues
No related issue. This is a direct fix for incorrect installation instructions found on the /en/download page.
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.