fix(ci): scorecard workflow failure fix#8456
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
|
Do you have docs or a reference for this action needing all these permissions? This seems like a lot of access to be giving? |
There was a problem hiding this comment.
Pull request overview
This PR addresses a scorecard workflow failure caused by insufficient read permissions. It adds explicit read permissions for multiple GitHub Actions scopes to the scorecard analysis job.
Key Changes:
- Adds 12 additional read permissions to the scorecard workflow job to resolve permission-related failures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avivkeller
left a comment
There was a problem hiding this comment.
I'm -1 on giving all these permissions explicitly, I'd rather figure out why it's requesting them and fix the issue wherever there may be
|
The reason for adding these permissions is that when the workflow tried to run without them, it failed with this error GitHub enforces that we must grant at minimum what a reusable workflow requests, even though the official Scorecard documentation only needs 4 permissions: So, either we grant all permissions the reusable workflow requests, or we implement the scorecard action directly in our workflow. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Let's figure out why the re usable workflow is requesting all these permissions, I assume it's requesting read all when it really doesn't have to |
|
Root Cause Found: I opened upstream issue: nodejs/web-team#82 to fix the root cause. |
Thanks for investigating it, @malav2110! |
|
@avivkeller can you double check we won't need this PR of any shape or form? |
Description
This PR fixes scorecard workflow failure due to limited read permissions.
Related Issues
#8455
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.