fix(AlertBox): override code styles in a markdown context#7890
Merged
avivkeller merged 2 commits intomainfrom Jun 26, 2025
Merged
fix(AlertBox): override code styles in a markdown context#7890avivkeller merged 2 commits intomainfrom
avivkeller merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the reliance on inherited text color for inline code elements to prevent unreadable white text in light contexts.
- Eliminates the
text-inheritutility oncodewithin markdown styles to allow explicit coloring. - Ensures code blocks can receive their own color rules rather than inheriting from parent.
Comments suppressed due to low confidence (1)
packages/ui-components/styles/markdown.css:92
- Removing the inherited text color means code elements may not have sufficient contrast by default; consider adding an explicit color utility (e.g.,
text-neutral-900 dark:text-neutral-100) to ensure readability across themes.
dark:max-xs:decoration-neutral-200;
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
==========================================
- Coverage 75.47% 75.46% -0.02%
==========================================
Files 101 101
Lines 8311 8311
Branches 218 218
==========================================
- Hits 6273 6272 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
AugustinMauroy
approved these changes
Jun 24, 2025
canerakdas
reviewed
Jun 24, 2025
6 tasks
a
ovflowd
reviewed
Jun 24, 2025
28fd545 to
2668054
Compare
2668054 to
24be41c
Compare
aa > code
Contributor
|
Lighthouse Results
|
Member
Author
Member
a > code1f9025f to
2a4c511
Compare
2a4c511 to
2f18159
Compare
Member
Author
|
In the Figma, there isn't a font change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
When the inherited text is white, the

codeelement does not have a readable contrast, as shown below:Validation
Everything on the website should look identical, but this should make a readable contrast on
api-docs-toolingRelated Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.