Revert "chore: refactor the generateBlogData function (#7607)"#7617
Merged
ovflowd merged 1 commit intonodejs:mainfrom Apr 3, 2025
Merged
Conversation
This reverts commit b7364b9.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
apps/site/next-data/generators/blogData.mjs:80
- [nitpick] Using an array to store the frontmatter with string keys is non-standard, which may be confusing. Consider using an object or Map for clearer intent when keying by filename.
rawFrontmatter[filename] = [0, ''];
bjohansebas
approved these changes
Apr 3, 2025
bjohansebas
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Member
|
Fast-tracking as it is affecting production! |
Contributor
Unit Test Coverage Report
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b7364b9.
Description
My change in #7607 actually causes blog tabs to 404s 😓
I'm really sorry for this, I must admit that I did not check my changes with
next build+next startbut only withnext devand my changes work perfectly fine with the latter 😓Since this effecting the production site I would assume that this need to be reverted asap, I'll anyways look into the issue and try to re-land the refactoring afterwords
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.