Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
MattIPv4
reviewed
Jan 21, 2025
|
|
||
| On Windows, a path that does not start with the file separator is treated as relative to the current directory. | ||
|
|
||
| This vulnerability affects Windows users of `path.join` API. |
Member
There was a problem hiding this comment.
Should this sentence include the impacted release lines like the other sections do?
Member
Author
There was a problem hiding this comment.
All release lines were impacted, but I think it's ok to mention
Member
Author
There was a problem hiding this comment.
Wait, we are mentioning it already, in the line below.
Member
There was a problem hiding this comment.
Yeh, the line below covers it, but for the other vulns we repeat it in this final sentence too. Was just a nit for consistency, not too worried either way.
MattIPv4
reviewed
Jan 21, 2025
richardlau
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs-private/security-release/pull/41
cc: @nodejs/tsc