Skip to content

sqlite: bind ArrayBuffer#62061

Open
mike-git374 wants to merge 5 commits intonodejs:mainfrom
mike-git374:bind-array-buffer
Open

sqlite: bind ArrayBuffer#62061
mike-git374 wants to merge 5 commits intonodejs:mainfrom
mike-git374:bind-array-buffer

Conversation

@mike-git374
Copy link

Fixes: #61396

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 1, 2026
Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (c9acf34) to head (1f2afe9).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62061      +/-   ##
==========================================
- Coverage   89.74%   89.64%   -0.11%     
==========================================
  Files         674      676       +2     
  Lines      204883   206242    +1359     
  Branches    39379    39506     +127     
==========================================
+ Hits       183882   184889    +1007     
- Misses      13279    13467     +188     
- Partials     7722     7886     +164     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.70% <33.33%> (-0.20%) ⬇️

... and 154 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer

3 participants