fs: avoid unhandled rejection in filehandle readableWebStream close#62053
Open
jorgitin02 wants to merge 1 commit intonodejs:mainfrom
Open
fs: avoid unhandled rejection in filehandle readableWebStream close#62053jorgitin02 wants to merge 1 commit intonodejs:mainfrom
jorgitin02 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: jorge guerrero <grrr.jrg@gmail.com>
Author
|
CC @nodejs/fs @nodejs/streams This PR targets #56116. What it changes:
Why:
Tests added:
Validation run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #56116
When FileHandle emits 'close', readableWebStream currently calls readableStreamCancel(readable) without handling rejection. If the stream has already errored (for example after EBADF), this can surface as an unhandled rejection.
This change consumes that cancel rejection on the close-notify path.
Tests: