Skip to content

lib: unify ICU and no-ICU TextDecoder #61409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ChALkeR wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

lib: unify ICU and no-ICU TextDecoder #61409

ChALkeR wants to merge 3 commits into from
+602 −285

Conversation

@ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jan 17, 2026 •
edited
Loading

Depends on #61118

Only the last commit belongs here

  1. Fix TextDecoder defaults to stream: true instead of false with null options #61411
  2. reduce duplication of TextDecoder source
  3. add utf-8 fast path to no-ICU version
  4. normalize how this[kHandle] was not set in no-ICU version
  5. The refactor changes the encoding reported in the no-ICU version when encoding is recognized but unsupported: now the actual resolved encoding name is reported as unsupported when previously the original input string was reported.
    I don't think this is major, and reporting the actual encoding name is better in that case.

This will allow further fixes and common fast path for UTF-16 / fixed impl for UTF-16 as string_decoder doesn't implement UTF-16 per spec.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2026

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 17, 2026
@ChALkeR ChALkeR changed the title Chalker/decoder/unify/1 lib: unify ICU and no-ICU TextDecoder Jan 17, 2026
@ChALkeR ChALkeR force-pushed the chalker/decoder/unify/1 branch 2 times, most recently from 367908c to 5a2317f Compare January 17, 2026 14:24
ChALkeR
ChALkeR commented Jan 17, 2026
View reviewed changes
@ChALkeR ChALkeR mentioned this pull request Jan 17, 2026
Open
@ChALkeR ChALkeR force-pushed the chalker/decoder/unify/1 branch from 5a2317f to d65e2da Compare January 17, 2026 14:46
ChALkeR and others added 3 commits January 17, 2026 18:50
@ChALkeR @mertcanaltin
src: move all 1-byte encodings to native
1d96511 
Co-authored-by: Mert Can Altin <mertgold60@gmail.com>
@ChALkeR @mertcanaltin
src: move all 1-byte encodings to native
4967625 
Co-authored-by: Mert Can Altin <mertgold60@gmail.com>
@ChALkeR
lib: unify ICU and no-ICU TextDecoder
90f6410
@ChALkeR ChALkeR force-pushed the chalker/decoder/unify/1 branch from d65e2da to 90f6410 Compare January 17, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextDecoder defaults to stream: true instead of false with null options

2 participants

@ChALkeR @nodejs-github-bot