Skip to content

src: use C++ nullptr in webstorage #61407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tniessen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use C++ nullptr in webstorage #61407

tniessen wants to merge 1 commit into from
+16 −12

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jan 17, 2026

Using the C-style constant 0 to represent a null pointer is less type safe than the C++-style constant nullptr, so we should always be using nullptr instead of 0.

@tniessen
src: use C++ nullptr in webstorage
e1b8516 
Using the C-style constant `0` to represent a null pointer is less type
safe than the C++-style constant `nullptr`, so we should always be using
`nullptr` instead of `0`.
@tniessen tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 17, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 17, 2026
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 17, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70846/

@codecov
Copy link

codecov bot commented Jan 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (2679b62) to head (e1b8516).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #61407   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         704      704           
  Lines      208796   208804    +8     
  Branches    40312    40314    +2     
=======================================
+ Hits       184828   184836    +8     
+ Misses      15955    15952    -3     
- Partials     8013     8016    +3
Files with missing lines Coverage Δ
src/node_webstorage.cc 74.74% <100.00%> (+0.13%) ⬆️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70858/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @nodejs-github-bot @addaleax @lpinca @cjihrig