Skip to content

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Jan 15, 2026

this is a fix for the previously added fature --test-rerun-failures
in a case there are nested ambiguous tests with the same name and same exact location, a following rerun won't run the failing test.
see the changes to the tests in this PR for a reproduction
the most effective way to solve this is to emit tests in the rerun for the entire tree of tests that have previously succeded - this also makes more sense in terms of the reproted output to the test stream

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 15, 2026
@MoLow MoLow force-pushed the fix-rerun-failures branch from 463e66e to 7f4ad48 Compare January 15, 2026 14:00
@MoLow MoLow force-pushed the fix-rerun-failures branch from 7f4ad48 to f7a886c Compare January 15, 2026 14:04
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.52%. Comparing base (2679b62) to head (f7a886c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/reporter/rerun.js 84.21% 6 Missing ⚠️
lib/internal/test_runner/test.js 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61392   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         704      704           
  Lines      208796   208841   +45     
  Branches    40312    40318    +6     
=======================================
+ Hits       184828   184884   +56     
- Misses      15955    15962    +7     
+ Partials     8013     7995   -18     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.29% <90.90%> (-0.06%) ⬇️
lib/internal/test_runner/reporter/rerun.js 92.20% <84.21%> (-7.80%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 15, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026
@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants