-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
test-runner: fix rerun ambiguous test failures #61392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MoLow
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
MoLow:fix-rerun-failures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+113
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
463e66e to
7f4ad48
Compare
7f4ad48 to
f7a886c
Compare
benjamingr
approved these changes
Jan 15, 2026
aymen94
approved these changes
Jan 15, 2026
atlowChemi
approved these changes
Jan 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61392 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 704 704
Lines 208796 208841 +45
Branches 40312 40318 +6
=======================================
+ Hits 184828 184884 +56
- Misses 15955 15962 +7
+ Partials 8013 7995 -18
🚀 New features to boost your workflow:
|
Collaborator
JakobJingleheimer
approved these changes
Jan 15, 2026
himself65
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix for the previously added fature
--test-rerun-failuresin a case there are nested ambiguous tests with the same name and same exact location, a following rerun won't run the failing test.
see the changes to the tests in this PR for a reproduction
the most effective way to solve this is to emit tests in the rerun for the entire tree of tests that have previously succeded - this also makes more sense in terms of the reproted output to the test stream