[v25.x] deps: V8: backport 209d2db9e24a

[kxxt]

This PR fixes JIT compilation error and disassembling error when enabling the RISC-V C extension in V8.

This is only need in v25.x, the v8 version on the main branch already contains the fix.

Original commit message:

[riscv] Fix compilation error and disassembling error when enabling the RISC-V C extension

Change-Id: I34a930f7bcda514698ce64d132cbe05fa32b323c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6934163
Reviewed-by: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#102431}

Refs: v8/v8@209d2db

Thanks for @luyahan for pointing out the fix and @RevySR for verifying it on node v25.2.1!

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/v8-update

[sxa]

@kxxt Just to check - this is an issue at runtime when you run with --riscv-c-extension? I was a bit confused by this issue saying it was a compilation failure and thought it was something that showed up when you were running the node build ...

Scratch that - have confirmed the problem with a v25.x-staging build and also that this fixes it. Failure was as follows:

sxa@bananapif3:~$ ./node25xs1-vanilla --riscv-c-extension


#
# Fatal error in , line 0
# Check failed: kMaxSizeOfMoveAfterFastCall == pc_offset() - before_offset.
#
#
#
#FailureMessage Object: 0x3fdc0423a0
----- Native stack trace -----

 1: 0x5aee44  [./node25xs1-vanilla]
 2: 0x1d48566 V8_Fatal(char const*, ...) [./node25xs1-vanilla]
 3: 0x116c8da  [./node25xs1-vanilla]
 4: 0x116ca70  [./node25xs1-vanilla]
 5: 0x11863b6  [./node25xs1-vanilla]
 6: 0xe1c616  [./node25xs1-vanilla]
 7: 0xe44fbe  [./node25xs1-vanilla]
 8: 0xe45546  [./node25xs1-vanilla]
 9: 0xe46a48  [./node25xs1-vanilla]
10: 0xe6ddc8  [./node25xs1-vanilla]
11: 0x12e5e24  [./node25xs1-vanilla]
Trace/breakpoint trap
sxa@bananapif3:~$ 

[kxxt]

@kxxt Just to check - this is an issue at runtime when you run with --riscv-c-extension? I was a bit confused by this issue saying it was a compilation failure and thought it was something that showed up when you were running the node build ...

Scratch that - have confirmed the problem with a v25.x-staging build and also that this fixes it. Failure was as follows:

sxa@bananapif3:~$ ./node25xs1-vanilla --riscv-c-extension


#
# Fatal error in , line 0
# Check failed: kMaxSizeOfMoveAfterFastCall == pc_offset() - before_offset.
#
#
#
#FailureMessage Object: 0x3fdc0423a0
----- Native stack trace -----

 1: 0x5aee44  [./node25xs1-vanilla]
 2: 0x1d48566 V8_Fatal(char const*, ...) [./node25xs1-vanilla]
 3: 0x116c8da  [./node25xs1-vanilla]
 4: 0x116ca70  [./node25xs1-vanilla]
 5: 0x11863b6  [./node25xs1-vanilla]
 6: 0xe1c616  [./node25xs1-vanilla]
 7: 0xe44fbe  [./node25xs1-vanilla]
 8: 0xe45546  [./node25xs1-vanilla]
 9: 0xe46a48  [./node25xs1-vanilla]
10: 0xe6ddc8  [./node25xs1-vanilla]
11: 0x12e5e24  [./node25xs1-vanilla]
Trace/breakpoint trap
sxa@bananapif3:~$ 

Ah, compilation error here should mean V8 JIT compilation error. I copied the words from the V8 commit msg, I have updated the description to avoid confusion.

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

[aduh95]

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

FYI it will be force pushed again next week when the security release gets released, you might prefer waiting for that before rebasing.

[kxxt]

It appears that the 25.x-staging branch has been force pushed. I will rebase this PR shortly.

FYI it will be force pushed again next week when the security release gets released, you might prefer waiting for that before rebasing.

Thanks for the heads up. Let's wait until the security release is done.

[kxxt]

I just saw the 25.3 security release on oss-security mailing list.

I have rebased this PR.

[kxxt]

I don't think the CI failures are related. This PR only touches V8 RISC-V code, which is not even compiled in the CI.