node-api: fix node_api_create_object_with_properties name

[vmoroz]

PR #59953 added the new napi_create_object_with_properties function to Node-API.
Unfortunately, we did not catch in the PR review that it uses the old function prefix.
This PR addresses the issue by renaming it to node_api_create_object_with_properties where we use the proper node_api_ prefix.

[nodejs-github-bot]

Review requested:

• @nodejs/node-api
• @nodejs/performance

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (842448b) to head (dfd1f3c).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61319      +/-   ##
==========================================
+ Coverage   88.00%   88.55%   +0.54%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40287      +91     
==========================================
+ Hits       183706   184841    +1135     
+ Misses      16992    15917    -1075     
+ Partials     8041     7981      -60     

Files with missing lines	Coverage Δ
src/js_native_api_v8.cc	76.49% <100.00%> (ø)

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[avivkeller]

This is a breaking change, don't we need to go through the usual deprecation process, even if it's a typo fix (like we did with util.getCallSite())?

[vmoroz]

This is a breaking change, don't we need to go through the usual deprecation process, even if it's a typo fix (like we did with util.getCallSite())?

Good point! I will add the original function back with the deprecated attribute.

[legendecas]

This is an experimental API and does not require a full cycle of breaking change or semver-major. This was also landed not long ago, so I'd argue that we should fix it sooner.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70836/