Skip to content

Conversation

@TheOneTheOnlyJJ
Copy link

Refs: #60618

This enables the SQLite Percentile extension added to the amalgamation with the release of SQLite v3.51.0 (#60614) by adding the SQLITE_ENABLE_PERCENTILE flag to both the GYP and GN SQLite builds.

The changes were made by following the pattern set by #57621.

This also addresses a minor review comment left unhandled in #57621 (comment).

A new test was added to test/parallel/test-sqlite.js to verify that the percentile() function is available at runtime. The test is placed immediately after the existing math functions test for two reasons:

  1. SQLITE_ENABLE_PERCENTILE follows SQLITE_ENABLE_MATH_FUNCTIONS alphabetically in the build configuration.
  2. percentile() is logically related to the mathematical function set.

This change does not enable the mentioned Carray extension from #60618 and does not include the SQLITE_ENABLE_ORDERED_SET_AGGREGATES flag for enabling the WITHIN GROUP syntax. Those are left for separate discussion and follow-up.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (bcdf2e0) to head (86b8170).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61295      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         704      704              
  Lines      208759   208739      -20     
  Branches    40281    40278       -3     
==========================================
- Hits       184816   184775      -41     
- Misses      15947    15981      +34     
+ Partials     7996     7983      -13     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheOneTheOnlyJJ TheOneTheOnlyJJ changed the title sqlite: Enable SQLite Percentile extension sqlite: enable SQLite Percentile extension Jan 8, 2026
@TheOneTheOnlyJJ TheOneTheOnlyJJ changed the title sqlite: enable SQLite Percentile extension sqlite: enable Percentile extension Jan 8, 2026
@TheOneTheOnlyJJ TheOneTheOnlyJJ force-pushed the sqlite-enable-percentile branch from 2ba1db0 to 86b8170 Compare January 9, 2026 09:38
@TheOneTheOnlyJJ
Copy link
Author

@geeksilva97

Since you worked on #57621 and this PR follows the same pattern, could you take a look at this?
It’s my first contribution to Node, and I based this directly on the work you did there.
The initial CI failure was due to improper commit message capitalization, which I fixed with a force-push.
I ran a local build and the relevant tests, and they pass.

@TheOneTheOnlyJJ
Copy link
Author

@cjihrig

Since this is not getting any activity lately, could you take a look at it so things get moving again?

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@nodejs-github-bot
Copy link
Collaborator

@geeksilva97
Copy link
Contributor

@geeksilva97

Since you worked on #57621 and this PR follows the same pattern, could you take a look at this? It’s my first contribution to Node, and I based this directly on the work you did there. The initial CI failure was due to improper commit message capitalization, which I fixed with a force-push. I ran a local build and the relevant tests, and they pass.

Sorry for the delay. LGTM

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants