-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
build: drop support for Python 3.9 #61177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test on Windows 11 25H2 with only Python |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
Waiting for resolution of build infrastructure issue nodejs/build#4208 to bump to minimum Python |
This comment was marked as resolved.
This comment was marked as resolved.
That's not the reason, most Collaborators also don't have access due to the security release that have been delayed, see https://nodejs.org/en/blog/vulnerability/december-2025-security-releases#update-17-dec-2025-security-release-target-january-7th. |
This comment was marked as outdated.
This comment was marked as outdated.
|
I see that some progress is being made in updating the build environment (PR nodejs/build#4215). Please let me know if there is anything that I should be doing, such as rebasing this PR. I do now have access to Jenkins at least, now that the security release has been completed. 👍🏻 |
Commit Queue failed- Loading data for nodejs/node/pull/61177 ✔ Done loading data for nodejs/node/pull/61177 ----------------------------------- PR info ------------------------------------ Title build: drop support for Python 3.9 (#61177) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MikeMcC399:drop-python39 -> nodejs:main Labels build, author ready, needs-ci, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 2 - build: drop support for Python 3.9 - add back missing bracket Committers 1 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/61177 Fixes: https://github.com/nodejs/node/issues/60919 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61177 Fixes: https://github.com/nodejs/node/issues/60919 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 26 Dec 2025 13:38:49 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613632689 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613700225 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613828398 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/61177#pullrequestreview-3615541772 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/61177#pullrequestreview-3615608194 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61177#pullrequestreview-3620571392 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-01-15T17:53:43Z: https://ci.nodejs.org/job/node-test-pull-request/70817/ - Querying data for job/node-test-pull-request/70817/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21047805954 |
Commit Queue failed- Loading data for nodejs/node/pull/61177 ✔ Done loading data for nodejs/node/pull/61177 ----------------------------------- PR info ------------------------------------ Title build: drop support for Python 3.9 (#61177) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MikeMcC399:drop-python39 -> nodejs:main Labels build, author ready, needs-ci, commit-queue-squash, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 2 - build: drop support for Python 3.9 - add back missing bracket Committers 1 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/61177 Fixes: https://github.com/nodejs/node/issues/60919 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61177 Fixes: https://github.com/nodejs/node/issues/60919 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 26 Dec 2025 13:38:49 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613632689 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613700225 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61177#pullrequestreview-3613828398 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/61177#pullrequestreview-3615541772 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/61177#pullrequestreview-3615608194 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61177#pullrequestreview-3620571392 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-01-15T22:00:51Z: https://ci.nodejs.org/job/node-test-pull-request/70817/ - Querying data for job/node-test-pull-request/70817/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21048070546 |
|
Landed in d73c49e |
Fixes: #60919
Situation
Python version
3.9reached end of life transition and has moved to the list of Python unsupported versions:Build scripts for current release lines should continue to allow using this version for the sake of build environment continuity.
Future Node.js release lines should not include the now unsupported Python 3.9 in build scripts.
Change
Remove Python 3.9 from build scripts. This is a
semver-majorchange.Similar to #55239 which dropped support for Python 3.8