Skip to content

Conversation

@npaun
Copy link
Contributor

@npaun npaun commented Dec 3, 2025

Fixes #58947. This implements the errorOnExists check for onDir, which we previously had only for onFile.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 3, 2025
@npaun npaun force-pushed the fix-fs-cp-errorOnExist-directory branch from 5d975d2 to b91cbae Compare December 3, 2025 20:39
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (746c3c2) to head (5c9b517).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60946      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         703      703              
  Lines      208406   208415       +9     
  Branches    40198    40200       +2     
==========================================
- Hits       184502   184478      -24     
- Misses      15901    15941      +40     
+ Partials     8003     7996       -7     
Files with missing lines Coverage Δ
lib/internal/fs/cp/cp.js 88.35% <100.00%> (-2.07%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowicz dario-piotrowicz self-requested a review December 3, 2025 22:00
@npaun npaun force-pushed the fix-fs-cp-errorOnExist-directory branch from b91cbae to 5c9b517 Compare December 3, 2025 22:06
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency in fs.cp operation

7 participants