support Node.js v26#1016
Open
IlyasShabi wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
IlyasShabi
commented
May 5, 2026
| #endif | ||
| } | ||
| inline v8::Local<v8::Object> Holder() const { | ||
| #if defined(NAN_HAS_PROPERTY_CALLBACK_INFO_HOLDER_V2) |
Member
Author
There was a problem hiding this comment.
IlyasShabi
commented
May 5, 2026
| #if defined(NAN_HAS_PROPERTY_CALLBACK_INFO_HOLDER_V2) | ||
| template<> | ||
| template <typename S> | ||
| inline void ReturnValue<void>::Set(const v8::Local<S> &) {} |
Member
Author
There was a problem hiding this comment.
Member
Author
|
I believe failure on Node.js v16 and v17 are not related to my changes 🤔 Can someone help on this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Node.js v26.
It comes with V8 14.6 which introduces breaking changes around
v8::PropertyCallbackInfo:Holder()is removed ->HolderV2().This()is removed.ReturnValue<void>::Set(Local<S>)no longer accepts object values