Fix edge case failures and complete string_view modernization in CommonJS lexer#3

Merged

anonrig merged 24 commits intomainfrom

copilot/fix-edge-case-failures

Jan 20, 2026

Commits on Jan 15, 2026

feat: port cjs-module-lexer from C to modern C++20
claude
committed
fix: improve shebang handling by updating lastTokenPos
claude
committed
docs: add comprehensive implementation notes and test analysis
claude
committed
Initial plan
Copilot
committed
Updated plan based on implementation notes analysis

Copilot
and
anonrig
committed
Merge PR implementation
Copilot
committed
Fix import.meta detection across whitespace/newlines

Copilot
and
anonrig
committed
Address code review feedback

Copilot
and
anonrig
committed
Fix bounds check for str_eq4 call

Copilot
and
anonrig
committed
Correct bounds check for str_eq4 - use <= not <

Copilot
and
anonrig
committed
Improve code comments and test readability

Copilot
and
anonrig
committed
Follow codebase pattern: use str_eq3 instead of str_eq4

Copilot
and
anonrig
committed
Add detailed comment explaining bounds check logic

Copilot
and
anonrig
committed
Fix shebang test by correcting test string with explicit newlines

Copilot
and
anonrig
committed
Fix literal_exports tests by handling require() and getter syntax

Copilot
and
anonrig
committed
Optimize character comparisons using str_eq helpers and isIdentifierChar

Copilot
and
anonrig
committed
Simplify code and optimize includes for maintainability

Copilot
and
anonrig
committed
Fix rollup_babel_reexports test by adding newlines after JS comments

Copilot
and
anonrig
committed
Fix typescript_reexports by deduplicating exports

Copilot
and
anonrig
committed
Fix division_regex_ambiguity test by improving regex detection heuristics

Copilot
and
anonrig
committed
Fix division_regex_ambiguity test - security check passed

Copilot
and
anonrig
committed
Fix non_identifiers count by filtering incomplete Unicode sequences

Copilot
and
anonrig
committed
Add string_view helper method for modernization

Copilot
and
anonrig
committed
Complete string_view modernization: replace all str_eq* functions

Copilot
and
anonrig
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix edge case failures and complete string_view modernization in CommonJS lexer#3

Fix edge case failures and complete string_view modernization in CommonJS lexer#3
anonrig merged 24 commits intomainfrom
copilot/fix-edge-case-failures

Commits on Jan 15, 2026

feat: port cjs-module-lexer from C to modern C++20

fix: improve shebang handling by updating lastTokenPos

docs: add comprehensive implementation notes and test analysis

Initial plan

Updated plan based on implementation notes analysis

Merge PR implementation

Fix import.meta detection across whitespace/newlines

Address code review feedback

Fix bounds check for str_eq4 call

Correct bounds check for str_eq4 - use <= not <

Improve code comments and test readability

Follow codebase pattern: use str_eq3 instead of str_eq4

Add detailed comment explaining bounds check logic

Fix shebang test by correcting test string with explicit newlines

Fix literal_exports tests by handling require() and getter syntax

Optimize character comparisons using str_eq helpers and isIdentifierChar

Simplify code and optimize includes for maintainability

Fix rollup_babel_reexports test by adding newlines after JS comments

Fix typescript_reexports by deduplicating exports

Fix division_regex_ambiguity test by improving regex detection heuristics

Fix division_regex_ambiguity test - security check passed

Fix non_identifiers count by filtering incomplete Unicode sequences

Add string_view helper method for modernization

Complete string_view modernization: replace all str_eq* functions