Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the project's dependency footprint by removing unnecessary packages and replacing a larger dependency with a smaller alternative. The changes maintain the same functionality while improving bundle size and reducing the number of dependencies.
- Replaces
lint-stagedwith the lighternano-stagedalternative - Removes
eslint-plugin-reactand its associated ESLint rules - Removes
@orama/plugin-data-persistencedependency and uses Orama's built-insavefunction instead
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates dependencies, removes unused packages, adds nano-staged configuration |
| src/generators/orama-db/index.mjs | Replaces persistence plugin with built-in save function and manual file writing |
| eslint.config.mjs | Removes React plugin and associated rules |
| .lintstagedrc.json | Removes lint-staged configuration file |
| .husky/pre-commit | Updates pre-commit hook to use nano-staged |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 70.80% 70.79% -0.01%
==========================================
Files 128 127 -1
Lines 11621 11623 +2
Branches 694 694
==========================================
+ Hits 8228 8229 +1
- Misses 3390 3391 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
(Whoops!) |
3b20dcb to
c8a2c81
Compare
|
Not sure why https://github.com/nodejs/api-docs-tooling/actions/runs/16353383603/job/46205598868?pr=360, the dependency shown was not added/removed in this PR, it was already a dependency, I believe. |
There was a problem hiding this comment.
I'm worried about these package replacements because eslint-plugin-react and lint-staged are more popular, have a more robust community, enterprise support, and after all, it's just dev dependencies, it doesn't affect the client bundle size anyway.
So I'm -1
The replacements are also good, and smaller and faster, I believe it's a good change. |
|
I can revert back to |
|
Bump @nodejs/web-infra |
This PR reduces our dependency count and size by:
eslint-plugin-reactwith a smaller alternative.lint-stagedwithnano-staged, see https://github.com/es-tooling/module-replacements/blob/main/docs/modules/lint-staged.md@orama/data-persistance, since Orama's builtinsavefunction has the same functionality