Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the patch coverage requirement in the Codecov configuration to allow continued improvements without enforcing a per-PR threshold.
- Removed the 80% patch coverage target and related TODO comments.
- Added
patch: falseunderstatusto disable patch coverage checks. - Left project coverage settings and TODO remarks in place.
Comments suppressed due to low confidence (2)
codecov.yml:4
- Ensure that
patch: falseis indented at the same level asprojectunderstatus, so the YAML parser correctly recognizes both keys.
patch: false
codecov.yml:7
- Update or remove this TODO since the rationale for project coverage thresholds has likely changed alongside disabling patch coverage enforcement.
# TODO(@avivkeller): Once our coverage > 70%,
AugustinMauroy
approved these changes
Jun 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage ? 66.57%
=======================================
Files ? 81
Lines ? 6956
Branches ? 339
=======================================
Hits ? 4631
Misses ? 2322
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flakey5
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we haven’t reached 80% coverage yet, our patch coverage threshold has successfully served its purpose by encouraging meaningful test coverage in our PRs. Now that we’re above 70%, I’m confident we can continue to improve coverage even without enforcing the threshold.