Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches Shiki’s syntax highlighter from the JavaScript regex engine to the faster Oniguruma WASM engine, reducing execution cost by ~50%.
- Replaced
createJavaScriptRegexEngineimport and usage withcreateOnigurumaEngine - Updated highlighter initialization to use dynamic WASM import
ovflowd
reviewed
Jun 25, 2025
ovflowd
approved these changes
Jun 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
===========================================
+ Coverage 51.15% 66.57% +15.42%
===========================================
Files 81 81
Lines 6956 6956
Branches 306 339 +33
===========================================
+ Hits 3558 4631 +1073
+ Misses 3395 2322 -1073
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
Jun 25, 2025
This was referenced Jun 25, 2025
Member
Author
|
Requesting fast-track so I can improve other aspects of Shiki's speed without conflicts. Edit: Nevermind, the improvement I had in mind did not improve speeds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the WASM generator rather than the JS one results in ~50% cheaper runs.