_.permutation and _.combination support for arrays#56
Open
wassname wants to merge 4 commits intonode4good:masterfrom
Open
_.permutation and _.combination support for arrays#56wassname wants to merge 4 commits intonode4good:masterfrom
wassname wants to merge 4 commits intonode4good:masterfrom
Conversation
Start of PR for node4good#47
https://gist.github.com/wassname/a882ac3981c8e18d2556, thanks to visangela on gist
wassname
changed the title
and _.combination` support for arrays
|
what happened.... now i have to randomly pick a permutation lodash addon at random with no idea if it's quality or trash :( |
|
Someone please merge this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
_.permutation,_.product, and_.combinationsupport for arrays. See Issue #47, as well as this gist. This also uses @visangela's fix, thanks.I've added unit tests and docstrings, but not docs (are these autogenerated).
Cheers