Conversation
…event signature wrapping attacks (node-saml#495)
Contributor
|
Given the number of people using xml-crypto and the lack of an alternative (that I'm aware of). It seems prudent to continue developing this. Otherwise, we should provide a migration guide to some other method of doing what this library does. |
# Conflicts: # README.md # src/signed-xml.ts
Author
|
I definitely don't want to encourage users to use xml signatures if they are building some new feature/product/spec. For SAML implementations, we can still support xml-crypto. |
This was referenced Oct 22, 2025
shunkica
added a commit
to shunkica/xml-crypto
that referenced
this pull request
Oct 23, 2025
- Add new XmlValidator class for signature validation - Keep SignedXml fully backward compatible - Incorporate security fixes from node-saml#493 - First step toward SigningReference/ValidationReference split Related: node-saml#517, node-saml#493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This significantly improves the security logic around xml-crypto.
Currently, it is an outline, i.e. the code doesn't actually work
Reviewers:
Currently we remove the checkSignature method from the SignedXML class to simplify the logic, and put it in XMLVerifier
Release process debate:
If feel like the best we can do is to deprecate the library entirely,
because xml signatures as a whole is unsafe, and using it will ensure the other side will be insecure. (since other implementations are insecure)