Conversation
|
any plans to merge this? |
|
@sibelius , yes, there are plans to merge this once it is done. Please feel free to contribute; I can use all the help I can get as recently I don't have much time for development on this project. |
| const keyInfoContent = this.getKeyInfoContent({ publicCert: this.publicCert, prefix }); | ||
| if (keyInfoAttrs || keyInfoContent) { | ||
| return `<${currentPrefix}KeyInfo${keyInfoAttrs}>${keyInfoContent}</${currentPrefix}KeyInfo>`; | ||
| const keyInfoXml = `<${currentPrefix}KeyInfo${keyInfoAttrs}>${keyInfoContent}<fake>2</fake></${currentPrefix}KeyInfo>`; |
|
should we remove whitespace before signing ? |
|
I'm checking the output from this reference implementation that works https://github.com/bacen/pix-dict-quickstart/blob/master/src/main/java/br/gov/bcb/pi/dict/xml/XMLSigner.java#L63 and the output of this package xml-crypto does not keep the \n inside ds:SignatureValue here is a print with the signature with \n should I implement or active this somehow ? I think this broke in your pull request, in main is working well |
|
@sibelius , sorry for not catching all these comments and thank you for your interest in this. It appears that some of the work that @shunkica has done in #506 might superceede this. He commented as much here. I'm waiting to hear back on him before I squander any more of yours or my time on this draft. Feel free to have a look at his work. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
This is to provide a helper function to sign all children of the root node and a way to include keyinfo in the signature.
Closes: #463