[patch] Gitter 'Join Chat' svg fix in README.MD #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown for including the Gitter 'Join Chat' SVG contained a space in the URL which broke the link, causing ugly headings to appear in all the generated machinepacks' README.MD files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikermcneil Hello Mike!
I noticed the repo was a bit stale, so I mention you to ensure you get the heads-up about this PR.
When I discovered the concept around Node-machines today I was browsing through a lot of the published machinepacks and noticed that most, if not all, repos had a broken image-link in their README.MD. Researching this I found out that the markdown for including the Gitter 'Join Chat' SVG contained a space in the URL which broke the link, causing the ugly headings to appear in all the generated machinepacks' README.MD files.
This patch just fixes that small bug in the template, but I still hope you find the contribution useful.
Thanks for your time!
Cheers!