Add screen argument to IPC wallpaper random#1697
Merged
ItsLemmy merged 2 commits intonoctalia-dev:mainfrom Mar 1, 2026
Merged
Conversation
* Add argument to specify on which screen to apply a random wallpaper * if `all` is provided, the old behavior is kept: a random wallpaper is applied to all screen.
…-random-wallpaper
Collaborator
|
Thanks for the PR, There are a couple things I need to fix, as stuff have evolved + some dangerous null != undefined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
I wanted to map a keybinding to change randomly the wallpaper of the current screen.
Implementation
Add argument to specify on which screen to apply a random wallpaper.
if
allis provided, the old behavior is kept: a random wallpaper is applied to all screen.Type of Change
Mark the relevant option with an "x".
I don't know how to add an optional argument to the function
IpcHandler.random. So the feature is not backward compatible. To have the previous behavior, we can passallas screen name.Related Issue
N/A
Testing
Describe how you tested your changes and mark the relevant items.
Test the IPC with the command line. I tested with different directories for each screen as well.
Screenshots / Videos
N/A
Checklist
How to update the IPC documentation ?
Additional Notes
Is it better to keep the feature as is (and break backward compatibility) ? Or should I create a new function in
IpcHandlerto keep the backward compatibility ?