feat(notifications): add file-based filtering rules#1454
Closed
ggyorfi wants to merge 1 commit intonoctalia-dev:mainfrom
Closed
feat(notifications): add file-based filtering rules#1454ggyorfi wants to merge 1 commit intonoctalia-dev:mainfrom
ggyorfi wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
Add NotificationRulesService for filtering notifications via ~/.config/noctalia/notification-rules.json Supported features: - Actions: show, block, mute (notoast, snooze, modify declared for future) - Match conditions: app_name, app_pattern, summary_pattern, body_pattern, body_contains, urgency (eq/lt/lte/gt/gte/in), category - Hot-reload on file change - Backward compatible (no rules file = no filtering)
64ee35b to
12e6bdc
Compare
Collaborator
|
I feel like this is too niche of a use case. Usually it's up to the application to offer proper control on notifications. Also even tho external configuration files are cool, nowhere in Noctalia we rely on direct text editing for configuration. This could probably be re-worked into a nice little plugin and I would be willing to accommodate an API change for the "evaluate" function to be run when a notification is processed, so that your plugin could work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds support for filtering notifications via
~/.config/noctalia/notification-rules.json. Users can block, mute, or allow notifications based on app name, content patterns, urgency, etc.Closes #1453
Type of Change
Testing
Manual testing performed:
Screenshots / Videos
N/A (no UI changes)
Checklist
Additional Notes
Assets/notification-rules-default.json