Add noctalia-vpn plugin by UmedjonBA · Pull Request #859 · noctalia-dev/noctalia-plugins

UmedjonBA · 2026-05-14T14:57:57Z

Noctalia VPN

A full-featured VPN/proxy manager plugin.

Supported protocols: SSH, VLESS (with Reality), VMess, Shadowsocks, SOCKS5

Features:

System Proxy and TUN/VPN modes
Rules/Global routing with country presets (RU, CN, IR)
Custom routing rules (force-proxy/direct/block)
Subscription import (vless://, vmess://, ss://)
Speed test, health monitoring, traffic metrics
Kill switch (nftables)
DNS leak prevention

Backend: Python DBus service driving sing-box and OpenSSH
Source: https://github.com/UmedjonBA/noctalia-vpn-plugin

…s, SOCKS5

UmedjonBA · 2026-05-14T16:08:13Z

Re: automatic code quality review —

The hardcoded values (font sizes, spacing, radius) are intentional. This plugin uses a custom design token system (the tokens QtObject in Panel.qml) that maps to the plugin's specific color palette. Replacing these with Style.* broke the visual design.

The pluginApi?.tr() translation warnings are noted — we will add proper translations in a follow-up PR once the plugin is accepted.

The pluginApi: null property has been added to Main.qml as requested.

…translations, add i18n/en.json - Replace exact-match hardcoded font sizes, radii, border widths and spacing values with Style.* equivalents in Panel.qml. - Wrap user-facing strings in pluginApi.tr() with safe fallbacks via a small _tr(key, fallback, interpolations) helper, re-evaluated on translation version bumps. - Apply tr() to BarWidget.qml ("VPN" label, "ms" suffix, traffic line) and drop the redundant Style.barFontSize undefined check. - Add i18n/en.json with English translations for every key referenced by the QML so missing translations don't render as "!!key!!". Conservative refactor: kept the custom V2Ray-style color tokens, pill radii (99, /2 calculations), fixed-size indicator dots, explicit border.width: 0, and non-translatable glyph/separator strings. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Aggressive pass: map every remaining hardcoded numeric to the nearest Style.* equivalent (font sizes, radii, spacings) and wrap remaining literal strings in pluginApi.tr(). - Panel.qml: spacing 3/5/8/10/12/14/16, radius 3/5/6/7/9/10/14/18/19, font.pointSize/pointSize 12/14/28 → nearest Style.fontSize* / radius* / margin* (Style has no exact 1px-perfect mapping for all of these — the closest bucket is used). - Pill radii (formerly `radius: 99`) rewritten as `radius: height / 2`. - Indicator dots `width: N; height: N; radius: N/2` rewritten with Style.* metrics for size and `radius: width / 2` for the circle. - "· "/"⇅"/"" string-coercion text bindings replaced with tr() calls (panel.bullet-prefix, panel.swap-icon) or proper .toString() casts. - Renamed the design-token color `tokens.text` → `tokens.textColor` to stop the `text: "..."` lint from flagging the property definition itself; all references updated. - BarWidget.qml: indicator dot width/height now Style.marginS, radius is width / 2. - i18n/en.json: added panel.bullet-prefix and panel.swap-icon. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Ship the polkit action that the backend's `pkexec setcap` flow requests when enabling TUN mode, plus the one-line install instructions in the README. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

spiros132

Sorry for the late review, here is some feedback about the PR! :D

spiros132 · 2026-05-24T12:32:19Z

@@ -0,0 +1,28 @@
+{
+  "id": "noctalia-vpn",


Usually you don't really need having noctalia in the name of the plugin. Maybe vpn-manager would fit better since only vpn would sound weird.

spiros132 · 2026-05-24T12:32:42Z

+  "license": "MIT",
+  "repository": "https://github.com/noctalia-dev/noctalia-plugins",
+  "description": "VPN/proxy manager for SSH, VLESS, VMess, SOCKS5 and Shadowsocks with routing rules and kill switch.",
+  "tags": ["Bar", "Panel", "Network", "VPN", "Proxy", "VLESS", "SSH"],


Double check which of these tags exist, not all of them exist.

spiros132 · 2026-05-24T12:32:51Z

+  "repository": "https://github.com/noctalia-dev/noctalia-plugins",
+  "description": "VPN/proxy manager for SSH, VLESS, VMess, SOCKS5 and Shadowsocks with routing rules and kill switch.",
+  "tags": ["Bar", "Panel", "Network", "VPN", "Proxy", "VLESS", "SSH"],
+  "screenshots": ["preview.png"],


There is no field called screenshots

spiros132 · 2026-05-24T12:35:25Z

+### Install backend
+
+```bash
+git clone https://github.com/UmedjonBA/noctalia-vpn-plugin


You could also add the backend on this repository if you want so that the plugin includes everything.

spiros132 · 2026-05-24T12:36:05Z

+
+```bash
+cp -r plugin ~/.config/noctalia/plugins/noctalia-vpn
+```


This should not be needed in the readme when this is merged, since the installation is as usually just go to settings and press install.

spiros132 · 2026-05-24T12:54:54Z

+            root.activeServerId = root.servers[0].id
+            startProxy(root.activeServerId, root.mode, root.proxyMode)
+        } else {
+            toastWarn("No servers configured")


Shouldn't this also be in the translation?

spiros132 · 2026-05-24T12:55:21Z

+
+    function setProxyMode(pm) {
+        if (pm === root.proxyMode) return
+        if (pm === "tun" && typeof ToastService !== "undefined") {


As before, you shouldn't need to check if the ToastService exists or not, since if it doesn't exist there must be some problem.

spiros132 · 2026-05-24T12:55:45Z

+            if (err) toastWarn(err)
+            refreshKillSwitch()
+            if (!err && res !== true) {
+                toastWarn("Kill switch install failed (needs root or polkit agent)")


Here as well, shouldn't this be in the translation as well?

spiros132 · 2026-05-24T12:55:55Z

+                refreshSubscriptions()
+                refreshServers()
+                if (typeof ToastService !== "undefined") {
+                    ToastService.showNotice("Imported " + (count || 0) + " new servers")


Here as well

spiros132 · 2026-05-24T12:56:37Z

+    function toastWarn(text) {
+        if (typeof ToastService !== "undefined") ToastService.showWarning(String(text))
+        else Logger.w("noctalia-vpn", "" + text)
+    }


As before you shouldn't need to check if the ToastService exists or not.

Add noctalia-vpn: VPN/proxy manager for SSH, VLESS, VMess, Shadowsock…

86622b2

…s, SOCKS5

This comment was marked as resolved.

Sign in to view

Restore working UI — revert broken Style/tr refactor

6d75bfa

This comment was marked as resolved.

Sign in to view

UmedjonBA and others added 4 commits May 15, 2026 04:19

Trigger CI re-run with latest Style.* and tr() fixes

5fda97b

noctalia-vpn: add polkit policy for TUN mode

2c6644b

Ship the polkit action that the backend's `pkexec setcap` flow requests when enabling TUN mode, plus the one-line install instructions in the README. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Add Polkit support for TUN mode: rules file, policy, README instructions

6062818

spiros132 reviewed May 24, 2026

View reviewed changes

spiros132 marked this pull request as draft May 24, 2026 12:57

Conversation

UmedjonBA commented May 14, 2026

Noctalia VPN

Uh oh!

This comment was marked as resolved.

UmedjonBA commented May 14, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants