Add niri-layout-indicator plugin#814
Draft
alnrog wants to merge 16 commits into
Draft
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Automatic Code Quality ReviewFile: plugins/niri-layout-indicator/BarWidget.qml
+ border.width: 1
+ text: "Keyboard layout"
+ text: "Display: " + (root.displayMode === "text" ? "text" : "flag")
+ text: "Middle click: " + (root.middleClickAction === "previous" ? "previous layout" : "toggle display")File: plugins/niri-layout-indicator/Settings.qml
+ return rootItem.pluginApi?.tr(key) || key |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
spiros132
reviewed
May 10, 2026
Collaborator
spiros132
left a comment
There was a problem hiding this comment.
Some feedback about the PR! :D
|
|
||
| ```bash | ||
| mkdir -p ~/.config/noctalia/plugins | ||
| cp -r niri-layout-indicator ~/.config/noctalia/plugins/ |
Collaborator
There was a problem hiding this comment.
This section isn't correct since the user can install the plugin just by pressing install.
| ### Quick install | ||
|
|
||
| ```bash | ||
| ./install.sh |
Collaborator
There was a problem hiding this comment.
This isn't correct either since there is no ./install.sh script and there shouldn't be any
|
|
||
| property var pluginApi: null | ||
|
|
||
| Timer { |
Collaborator
There was a problem hiding this comment.
Why is this timer needed in the first place?
| Layout.preferredWidth: 600 | ||
| Layout.preferredHeight: 0 | ||
| visible: false | ||
| } |
Collaborator
There was a problem hiding this comment.
This Item to enforce minimum width shouldn't be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Niri Layout Indicator plugin.
A native Noctalia Shell bar widget for niri that displays and switches keyboard layouts.
Features: