Skip to content

chore: add some missing testnet upgrades#31

Merged
MalteHerrmann merged 3 commits intomainfrom
add-past-testnet-upgrades
Nov 14, 2025
Merged

chore: add some missing testnet upgrades#31
MalteHerrmann merged 3 commits intomainfrom
add-past-testnet-upgrades

Conversation

@MalteHerrmann
Copy link
Copy Markdown
Contributor

@MalteHerrmann MalteHerrmann commented Nov 14, 2025

Summary by CodeRabbit

  • Documentation

    • Expanded Testnet upgrade table with v10.0.0-beta.0, v10.0.0-rc.2, v10.0.0-rc.3, v10.0.1, v11.0.0-beta.0, v11.0.0-rc.1, and v11.1.0-rc.1 including start heights, release links, and notes column (some entries include halt height or empty notes).
    • Updated node-running docs: renamed page title, removed an ending sentence, and adjusted sidebar category entries.
  • Chores

    • Added Python-related ignore patterns (cache and virtual environment) to version control ignore list.

@MalteHerrmann MalteHerrmann self-assigned this Nov 14, 2025
@MalteHerrmann MalteHerrmann added the documentation Improvements or additions to documentation label Nov 14, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 14, 2025

Walkthrough

Updated documentation and repo metadata: expanded the Testnet chain-upgrades table with multiple new release rows and a Notes column; added/removed several docs category files and small content edits in running-a-node pages; added Python-related ignores to .gitignore.

Changes

Cohort / File(s) Change Summary
Testnet upgrades table
docs/build/chain-upgrades/testnet.mdx
Added multiple new upgrade entries (v10.0.0-beta.0, v10.0.0-rc.2, v10.0.0-rc.3, v10.0.1, v11.0.0-beta.0, v11.0.0-rc.1, v11.1.0-rc.1); introduced a new Notes column; added start heights and release links; v10.0.0-rc.3 includes a halt-height note.
Running-a-node docs
docs/build/running-a-node/index.mdx, docs/build/running-a-node/full-archive.mdx, docs/build/running-a-node/_category_.json
Renamed page title text in index.mdx; removed one trailing line from full-archive.mdx; added a new category file _category_.json for "Running A Node".
Sidebar/category removal
docs/build/running-your-own-node/_category_.json
Removed the existing Docusaurus category definition for "Running Your Own Node".
Repo ignore
.gitignore
Added Python-related ignore patterns (__pycache__, .venv).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Mostly documentation and metadata edits; low logic risk.
  • Pay extra attention to:
    • Version strings, start heights, and release links in testnet.mdx.
    • Correctness of renamed/added category file (docs/build/running-a-node/_category_.json) vs removed one to avoid sidebar duplication or broken links.

Suggested reviewers

  • johnletey
  • 0xstepit

Poem

🐰 I hopped through docs at break of day,

Added rows where upgrades lay,
Heights and links in tidy line,
A halt noted — all looks fine,
🥕 Cheers from a rabbit, small and spry.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'chore: add some missing testnet upgrades' directly reflects the primary change: adding multiple new testnet upgrade entries to the upgrades table. The title is concise, specific, and clearly summarizes the main modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-past-testnet-upgrades

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2605f30 and dd21eb0.

📒 Files selected for processing (6)
  • .gitignore (1 hunks)
  • docs/build/chain-upgrades/testnet.mdx (1 hunks)
  • docs/build/running-a-node/_category_.json (1 hunks)
  • docs/build/running-a-node/full-archive.mdx (0 hunks)
  • docs/build/running-a-node/index.mdx (1 hunks)
  • docs/build/running-your-own-node/_category_.json (0 hunks)
💤 Files with no reviewable changes (2)
  • docs/build/running-a-node/full-archive.mdx
  • docs/build/running-your-own-node/category.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-10T07:43:26.460Z
Learnt from: johnletey
Repo: noble-assets/docs PR: 22
File: docs/chain-upgrades/mainnet.mdx:30-37
Timestamp: 2025-09-10T07:43:26.460Z
Learning: Mintscan uses `/block/` in their URLs (e.g., https://www.mintscan.io/noble/block/119000), not `/blocks/`. This is the canonical format that should be used for Mintscan block links in documentation.

Applied to files:

  • docs/build/chain-upgrades/testnet.mdx
🔇 Additional comments (4)
.gitignore (1)

22-24: Good addition of Python ignore patterns.

The added patterns appropriately cover standard Python artifacts. The organization with a # Python comment follows the existing file structure well.

Minor note: .venv only matches at the root level, while **/__pycache__ matches recursively. If the project may have virtual environments in subdirectories (e.g., when working with monorepos or multiple environments), consider using **/.venv for consistency. Otherwise, the current pattern is appropriate for typical single-venv-at-root setups.

docs/build/running-a-node/_category_.json (1)

1-7: Configuration structure looks good.

The Docusaurus category configuration is correctly formatted and the label–document link alignment is appropriate for the reorganized documentation structure.

docs/build/running-a-node/index.mdx (1)

2-2: Title update aligns with the category reorganization.

The title change from "Running Your Own Node?" to "Running A Node" improves clarity and consistency with the new sidebar category label.

docs/build/chain-upgrades/testnet.mdx (1)

21-28: No changes needed — the testnet upgrade table is complete and accurate.

Verification confirms no references to v10.0.0-rc.0 or v10.0.0-rc.1 exist anywhere in the repository, indicating these versions were not deployed on testnet. The documented sequence (v10.0.0-beta.0 → v10.0.0-rc.2 → v10.0.0-rc.3 → v10.0.1) reflects the actual upgrade chain. The previously flagged missing v10.0.0-rc.2 has been correctly added at line 23, and all Mintscan block links use the correct /block/ format.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread docs/build/chain-upgrades/testnet.mdx Outdated
Comment thread docs/build/chain-upgrades/testnet.mdx Outdated
@MalteHerrmann MalteHerrmann merged commit deaa36a into main Nov 14, 2025
4 checks passed
@MalteHerrmann MalteHerrmann deleted the add-past-testnet-upgrades branch November 14, 2025 20:05
@coderabbitai coderabbitai Bot mentioned this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants