Open
Conversation
added 2 commits
April 9, 2019 15:17
The new test case verifies the current behavior that no exceptions are thrown if a key mentioned in a template is not found. The Catch2 TEST_CASE macro was used directly instead of the MSTCH_TEST or other macros because this test case does not verify output of the mstch::render with a given input, what MSTCH_TEST and friends are for. Signed-off-by: Hannu Lounento <hannu.lounento@vaisala.com>
Throwing an exception enables clients to detect failures to render template completely due to missing keys. This is useful in cases where clients expect templates and the data structure to always match and treat missing keys as failures. Define a custom exception to enable clients to identify the specific type of the error. Signed-off-by: Hannu Lounento <hannu.lounento@vaisala.com>
|
Ignoring the code (although it looks fine to me), I'm +1 on this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for throwing an exception if a key referenced by a template is not found. This is useful for clients that want to ensure templates and the related input data structure match and want to handle potential mismatches as failures.
P.S. I also rebased the patches against torbjoernk/mstch branch develop and pushed to the branch torbjoernk/report-missing-keys as some of the other open pull requests have been merged there.