🔧 fix build in c++17 on GCC libstdc++ and on clang+libc++.#25
Open
daminetreg wants to merge 1 commit intono1msd:masterfrom
Open
🔧 fix build in c++17 on GCC libstdc++ and on clang+libc++.#25daminetreg wants to merge 1 commit intono1msd:masterfrom
daminetreg wants to merge 1 commit intono1msd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @no1msd,
I've been working recently on a C++17 project and I've integrated your library. I also had to compile it under libc++ on macOS.
It happens that allowing copying of std::map with const keys is not a required feature from the C++ standard, libstdc++ has an implementation that allows it but libc++ not.
Therefore this patch does the following :
If you don't like the third change I can push a toolchain file that sets the config or reinstate it with a cmake build option.
Thank you very much for the awesome mstch library. It is a really good foundation.
Cheers,