Do not hardcode Release as the build type and expose Boost_INCLUDE_DIR#16
Open
MaxLeb wants to merge 3 commits intono1msd:masterfrom
Open
Do not hardcode Release as the build type and expose Boost_INCLUDE_DIR#16MaxLeb wants to merge 3 commits intono1msd:masterfrom
MaxLeb wants to merge 3 commits intono1msd:masterfrom
Conversation
MaxLeb
changed the title
rcari
force-pushed
the
mleblanc/fixCMake
branch
from
00f0652 to
5ac5b31
Compare
Author
|
@no1msd, any change this could be merged ? There are a some PR that are waiting and that could improve the lib a little bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch gives developers a little bit of flexibility for the build type.
mstchsince some public headers include Boost's headers.