-
Notifications
You must be signed in to change notification settings - Fork 1
Release OpenID4VC #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tnotheis
wants to merge
131
commits into
main
Choose a base branch
from
release/openid4vc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release OpenID4VC #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime into poc-credo-holder-in-app-runtime
* refactor: remove unused code * feat: throw when unimplemented methods are used --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: remove duplicate dependency declaration * fix: return proper json from ResolveCredentialOffer
* chore: remove dto * chore: remove export
* chore: bump credo * fix: store legacy key id * fix: re-add encoded credential * test: remove only * refactor: remove comment * fix: only re-add for PEX
* chore: audit fix * chore: formatting * chore: formatting
* chore: bump credo * test: make jest work * test: slimmer jest config * test: apply the fixes in other package.jsons too * ci: remove audit exclude
* chore: move skipLibCheck comment * refactor: reuse holder in OpenId4VcController * refactor: move keyStorage init
* feat: separate requestCredentials from acceptCredentials * chore: build schemas * test: use new functions * chore: audit fix * chore: jsonparse stringifySafe REquestCredentialsResponse * refactor: rename storeCredentials * chore: save change in index file * chore: run build * fix: it works for now --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julian König <julian.koenig@js-soft.com>
* test: add mdoc test * fix: be more lenient * test: restructure tests * chore: update images * fix: cleanup merge * refactor: naming usedCredentials -> matchingCredentials
* fix: remove hacky key solution * feat: add ShareCredentialOfferRequestItem * feat: add empty ShareCredentialOfferRequestItemProcessor * feat: add event * refactor: move code to OpenId4VciCredentialResponseJSON * feat: implement processor * feat: add ShareCredentialOfferRequestItemDVO * test: add test * fix: build schemas * chore: remove comments * fix: add request item to check * refactor: naming * fix: use nameof * refactor: types * chore: use property directly * fix: add error cause to ValidationResult error message * chore: naming * fix: event namespace + wording * fix: use typed property * fix: stuff * chore: one-liner
* chore: bump credo * ci: bump oid4vc service image --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: remove hacky display fetching method * chore: formatting
…redentialCacheEntry (#893) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: WIP * feat: add retry * chore: add log * feat: implement processOpenID4VPURL * fix: renamings * fix: remove duplicated code * chore: add another error code * fix: update fake ui bridge * chore: implement MockUIBridge * fix: proper error * chore: timos hidden PR comments * Update packages/app-runtime/test/lib/MockUIBridge.matchers.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/app-runtime/test/lib/MockUIBridge.matchers.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: remove test * refactor: move error --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* chore: add check * fix: only show error on check * chore: trigger ci
* feat: add pin secured VC test * working version * feat: add pin secured VC test * working version * fix: bad merge * fix: simplify token passing * fix: remov unnecessary linting directive * refactor: some initial code clean up * fx: remove accidental change * chore: readd missing test * fix: use correct version * chore: update schemas * fix: transfer token in a proper manner and only allow token or pin * feat: add pin secured VC test * working version * fix: bad merge * feat: add pin secured VC test * working version * fix: simplify token passing * refactor: some initial code clean up * fx: remove accidental change * chore: readd missing test * fix: use correct version * chore: update schemas * fix: transfer token in a proper manner and only allow token or pin * chore: update the lockfile * chore: undo changes * feat: call external authentication through UI bridge * feat: improve OAuth errors * feat: dont show error when auth is cancelled * fix:remove duplicate test * test if auth servers are empty * refactor: inline unecessary type object * refactor: inline unecessary type object * refactor: fix datatype for good * chore: improve ui bridge function naming * fix: simplify logic * fix: improve type safety * chore: remove unecessary comments and variables * chore: remove unecessary comments and variables --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julian König <julian.koenig@js-soft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist