Skip to content

Conversation

@tnotheis
Copy link
Member

@tnotheis tnotheis commented Nov 6, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

erbenjak and others added 30 commits August 20, 2025 14:20
mergify bot and others added 5 commits November 24, 2025 16:55
* refactor: remove unused code

* feat: throw when unimplemented methods are used

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: remove duplicate dependency declaration

* fix: return proper json from ResolveCredentialOffer
* chore: remove dto

* chore: remove export
@mergify mergify bot mentioned this pull request Nov 26, 2025
4 tasks
Magnus-Kuhn and others added 24 commits November 27, 2025 16:03
* chore: bump credo

* fix: store legacy key id

* fix: re-add encoded credential

* test: remove only

* refactor: remove comment

* fix: only re-add for PEX
* chore: audit fix

* chore: formatting

* chore: formatting
* chore: bump credo

* test: make jest work

* test: slimmer jest config

* test: apply the fixes in other package.jsons too

* ci: remove audit exclude
* chore: move skipLibCheck comment

* refactor: reuse holder in OpenId4VcController

* refactor: move keyStorage init
* feat: separate requestCredentials from acceptCredentials

* chore: build schemas

* test: use new functions

* chore: audit fix

* chore: jsonparse stringifySafe REquestCredentialsResponse

* refactor: rename storeCredentials

* chore: save change in index file

* chore: run build

* fix: it works for now

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* test: add mdoc test

* fix: be more lenient

* test: restructure tests

* chore: update images

* fix: cleanup merge

* refactor: naming usedCredentials -> matchingCredentials
* fix: remove hacky key solution

* feat: add ShareCredentialOfferRequestItem

* feat: add empty ShareCredentialOfferRequestItemProcessor

* feat: add event

* refactor: move code to OpenId4VciCredentialResponseJSON

* feat: implement processor

* feat: add ShareCredentialOfferRequestItemDVO

* test: add test

* fix: build schemas

* chore: remove comments

* fix: add request item to check

* refactor: naming

* fix: use nameof

* refactor: types

* chore: use property directly

* fix: add error cause to ValidationResult error message

* chore: naming

* fix: event namespace + wording

* fix: use typed property

* fix: stuff

* chore: one-liner
* chore: bump credo

* ci: bump oid4vc service image

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: remove hacky display fetching method

* chore: formatting
…redentialCacheEntry (#893)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: WIP

* feat: add retry

* chore: add log

* feat: implement processOpenID4VPURL

* fix: renamings

* fix: remove duplicated code

* chore: add another error code

* fix: update fake ui bridge

* chore: implement MockUIBridge

* fix: proper error

* chore: timos hidden PR comments

* Update packages/app-runtime/test/lib/MockUIBridge.matchers.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update packages/app-runtime/test/lib/MockUIBridge.matchers.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore: remove test

* refactor: move error

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* chore: add check

* fix: only show error on check

* chore: trigger ci
* feat: add pin secured VC test

* working version

* feat: add pin secured VC test

* working version

* fix: bad merge

* fix: simplify token passing

* fix: remov unnecessary linting directive

* refactor: some initial code clean up

* fx: remove accidental change

* chore: readd missing test

* fix: use correct version

* chore: update schemas

* fix: transfer token in a proper manner and only allow token or pin

* feat: add pin secured VC test

* working version

* fix: bad merge

* feat: add pin secured VC test

* working version

* fix: simplify token passing

* refactor: some initial code clean up

* fx: remove accidental change

* chore: readd missing test

* fix: use correct version

* chore: update schemas

* fix: transfer token in a proper manner and only allow token or pin

* chore: update the lockfile

* chore: undo changes

* feat: call external authentication through UI bridge

* feat: improve OAuth errors

* feat: dont show error when auth is cancelled

* fix:remove duplicate test

* test if auth servers are empty

* refactor: inline unecessary type object

* refactor: inline unecessary type object

* refactor: fix datatype for good

* chore: improve ui bridge function naming

* fix: simplify logic

* fix: improve type safety

* chore: remove unecessary comments and variables

* chore: remove unecessary comments and variables

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants