clarify code to calculate time delay from spawn to settlement #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantaylor-NOAA
approved these changes
Aug 28, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
@Rick-Methot-NOAA, thanks for all the comments on the code to clarify what's happening. I've just looked through the changes but am trusting that your model testing was adequate so not trying to repeat that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Additional work on time delay (in number of seasons) between spawning and settlement.
What tests have been done?
using simple_small
I examined many permutations of: N seasons, spawn_month, settlement_month and settlement_age. Used a specified recdev to put a pulse in the numbers-at-age matrix. In all cases, the pulse showed up in the expected year, season and age.
Some output to echoinput.sso has been clarified and the code documentation also.
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
None, but be watchful.
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).