156 replace alerts #205
Open
156 replace alerts #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nlyra
commented
Jul 13, 2021
nlyra
commented
- Created a versatile/dynamic dialog component where you can pass props to it from any page or component.
- Implemented this component and replaced alerts (where applicable), as well as new styling for current dialogs.
- If anyone needs to add dialogs in the future, they can use this component with the necessary props.
Merging Dev onto Main to update the old files
Merge dev into main
…ts that have a reroute were not changed so that they could still appear after rerouting to new page. All other alerts are now dialogs.
dmols
requested changes
Jul 14, 2021
Collaborator
dmols
left a comment
dmols
left a comment
There was a problem hiding this comment.
Dialog for create new course (or attempting to when you don't have all required values listed) shows a dialog with a weird scrollbar at the bottom of it. Also, if you didn't mean to change the profile error alert (changing email to one without the @) for a dialog, then you're good there. Otherwise, that's missing too. Everything else looks good!
Collaborator
|
Need another dialog for submitting a quiz. Sorry for the late notice, I just saw this while checking Michael's PR. |
collyntheshots
approved these changes
Jul 15, 2021
Collaborator
collyntheshots
left a comment
collyntheshots
left a comment
There was a problem hiding this comment.
Beyond whats been said i cant think of anywhere else theyre needed, everything should be good to go
mbrancato31
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.