Fix(compare): Handle missing items in CompareItemsHandler #323
Closed
Askeban wants to merge 2 commits intonlweb-ai:mainfrom
Closed
Fix(compare): Handle missing items in CompareItemsHandler #323Askeban wants to merge 2 commits intonlweb-ai:mainfrom
Askeban wants to merge 2 commits intonlweb-ai:mainfrom
Conversation
This commit addresses an issue where the CompareItemsHandler would crash with a KeyError if one or both of the items to be compared were not found. The fix involves the following changes: - Modified the `do` method in `CompareItemsHandler` to use `.get()` for safer dictionary access, preventing the `KeyError`. - Updated the `_send_no_items_found_message` method to send a more informative message, indicating which of the items were found. - Corrected a typo in a log message within the `do` method's exception handler. - Added a new test file `test_compare_items.py` with unit tests to cover scenarios where one or both items are not found. These changes ensure that the system gracefully handles cases where items are not found and provides better feedback to the user. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Collaborator
|
Thanks for the contribution! Closing this as the codebase has changed significantly since this was opened (notably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the CompareItemsHandler would crash
with a KeyError if one or both of the items to be compared were not
found.
The fix involves the following changes:
domethod inCompareItemsHandlerto use.get()forsafer dictionary access, preventing the
KeyError._send_no_items_found_messagemethod to send a moreinformative message, indicating which of the items were found.
domethod's exceptionhandler.
test_compare_items.pywith unit tests tocover scenarios where one or both items are not found.
These changes ensure that the system gracefully handles cases where
items are not found and provides better feedback to the user.