Open
Conversation
# Conflicts: # CMakeLists.txt # metaconfigure/description.json
But that modern component isn't done yet.
# Conflicts: # CMakeLists.txt # src/njoy21.hpp
…s, as metaconfigure isn't playing nice.
# Conflicts: # CMakeLists.txt # cmake/develop_dependencies.cmake # src/njoy21.hpp # src/njoy21/Driver/Factory/src/setupModernDirectory.hpp # src/njoy21/modern.hpp # src/njoy21/modern/Sequence/Factory.hpp # src/njoy21/modern/Sequence/Factory/src/parse.hpp # src/njoy21/modern/Sequence/routines.hpp # tests/47/CMakeLists.txt # tests/47/referenceTape45 # tests/47/referenceTape47 # tests/47/referenceTape55 # tests/47/referenceTape57 # tests/48/CMakeLists.txt # tests/49/CMakeLists.txt # tests/49/input # tests/49/referenceTape71 # tests/50/CMakeLists.txt # tests/50/referenceTape33 # tests/50/referenceTape34 # tests/51/CMakeLists.txt # tests/51/referenceTape33 # tests/51/referenceTape34 # tests/52/CMakeLists.txt # tests/52/referenceTape33 # tests/52/referenceTape34 # tests/53/CMakeLists.txt # tests/53/referenceTape33 # tests/53/referenceTape34 # tests/54/CMakeLists.txt # tests/54/referenceTape33 # tests/54/referenceTape34
Draft
Member
Author
|
The latest update 54e82e2 moves this Pull Request out of draft mode.
The attached RegressionTests.pdf shows the checks that have been done to try and identify what the changes are in the all the regression tests. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds the modern RECONR module to NJOY21.