Open
Conversation
Owner
|
Thanks for issuing a pull request. I would need to look at this a bit more thoroughly before merging it back, because right now the entire layout would be invalidated many times during scrolling, and I think that will adversely affect performance. |
Contributor
Author
|
Yes I'm totally agree. If I've got some time to investigate, I'll improve my code, and pull request back. |
Conflicts: NHBalancedFlowLayout/NHBalancedFlowLayout.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just modify the layout to have sticky header (like in
UITableView) in option. By default,stickyHeadersis set to no.I don't know if you wanted this feature. I had to implement it for my app, so I sent you a pull request for this feature. If you don't want it in your component, feel free to refuse the pull request :).
R.